db,pm: avoid redeeming expired tickets #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jailuthra I just tagged you in case you might be interested in these areas of the codebase, please don't feel obligated to review this ! |
5 tasks
kyriediculous
force-pushed
the
nv/avoid-redeem-expired-tix
branch
2 times, most recently
from
8e00158 to
3a458d2
Compare
yondonfu
requested changes
Oct 19, 2020
yondonfu
approved these changes
Oct 21, 2020
kyriediculous
force-pushed
the
nv/avoid-redeem-expired-tix
branch
from
f0ed105 to
a46f215
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This PR avoids the redemption of expired winning tickets.
Specific updates (required)
SelectEarliestWinningTicketandWinningTicketCountto take in aminCreationRoundparameter. ThecreationRoundfor tickets stored would have to be greater or equal to this value to be considered a non-expired ticket (the expiry is two rounds)How did you test each of these updates (required)
Added unit tests , cherry picked this onto the Livepool orchestrator and observe my stale ticket is no longer being retried endlessly.
Does this pull request close any open issues?
Fixes #1594
Fixes #632
Checklist:
./test.shpass